Repository navigation
Conversation
Signed-off-by: Thijs226 <178910307+Thijs226@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both generated manifests omit
storage, although the background script, logger and popup usebrowserAPI.storage.local. In a fresh Chromium installation,chrome.storageis undefined: installation statistics and save counts never persist, diagnostic entries are discarded, and rating preferences cannot be saved.Add
storageto the shared manifest template for Chrome and Firefox, update the existing manifest contract test, and document the local data in the README and privacy policy. No new data collection or network behavior is introduced.Verified on a disposable VPS workspace:
The permission requirement is documented by Chrome and Mozilla. Firefox's generated manifest is covered by tests; the live browser check used Chromium.