-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printdesks command #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your efforts and contribution.
Your implementation, unfortunately, adds a lot of overhead, listeners and new code that imo is not necessary.
As mentioned in one of the review comments, all this can be achieved without adding new structures, by simply iterating over the vdesks
. Please, correct me if I'm wrong here.
Just to be clear, I'm not against implementing this functionality, it's just that your proposition adds too much complexity :)
I'd merge this pull request as a squash merge since the pull request contains some commits which were updated the last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Hi
I've added the
hyprctl printdesks
command which outputs information about all vdesks currently availableThe output below is an example of running
hyprctl printdesks -j
which can be easily processed by other applications (e.g. sidebar widgets):Now, the plugin stores a list with all open windows for every vdesk which has to be updated when a window opens, closes or gets moved to another workspace (which potentially is part of another vdesk). Therefore, it was necessary to add some event listeners.
The branch is rebased onto
dev
and therefore the new feature will be available for all users as soon as the next hyprland version is released.