bumped deps and added node 8 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 38d9d70 on updated-deps into ** on master**. |
|
Changes Unknown when pulling 38d9d70 on updated-deps into ** on master**. |
Collaborator
|
This issue digitalbazaar/jsonld.js#167 requires us to stay pinned at |
Collaborator
Author
|
I just pushed, but the tests are still not passing. |
|
Changes Unknown when pulling aab1937 on updated-deps into ** on master**. |
Collaborator
|
Which ones aren't passing?
|
Collaborator
Author
But it might have been flaky, it's passing now. |
Collaborator
|
Cool.There’s some potential url resolution going on there if I recall, so that might be what makes it flaky.
…--
Jun Matsushita
Founder, CEO
iilab - information innovation lab - iilab.org - @iilab
cell +49 157 530 86174
xmpp jun@jabber.ccc.de
pgp D38A 5502 7387 3BF4 B330 7DA2 2A07 F70C A036 E792
From: Matteo Collina <notifications@github.com>
Reply: levelgraph/levelgraph-jsonld <reply@reply.github.com>
Date: 5 June 2017 at 17:35:19
To: levelgraph/levelgraph-jsonld <levelgraph-jsonld@noreply.github.com>
Cc: Jun Matsushita <jun@iilab.org>, Review requested <review_requested@noreply.github.com>
Subject: Re: [levelgraph/levelgraph-jsonld] bumped deps and added node 8 (#65)
1) IRI keeps @id as IRI
But it might have been flaky, it's passing now.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jmatsushita please have a look as tests are failing due to the updated deps.