upgrade of all npm dependencies #32
Conversation
|
i'm having a strange "works on my machine" moment ... need to investigate a bit more |
.travis.yml
Outdated
| language: node_js | ||
| node_js: | ||
| - 0.10 | ||
| - 5 |
There was a problem hiding this comment.
This should be 0.10, 0.12, 4, 5
|
Let me know when it's done :). |
capricube
force-pushed
the
npm-upgrade
branch
5 times, most recently
from
00b59f3 to
00cded7
Compare
|
finally i found the problem. it was a hard nut to crack! FYI: in order to make the tests work with the updated dependencies i had to downgrade level-test from 2.0.1 to 1.7.0. The tests didn't work on travis because they where executed using the in-memory leveldown (memdown) implementation. When i executed it locally i always had a leveldown dependency and everything worked. Only after i changed the |
| language: node_js | ||
| node_js: | ||
| - 0.10 | ||
| - "5" |
There was a problem hiding this comment.
this should be 0.10, 0.12, 4, 5
|
Good work! There are just a couple of nits to fix. |
only had to change N3Util.isUrl() call to N3Util.isIRI(). And upgrade travis.yml file to use latest node and npm version.
|
do we really need support for node 0.10 and 0.12? Those two are failing... |
|
0.10 and 0.12 are currently supported by this library and by levelgraph (https://github.com/mcollina/levelgraph/blob/master/.travis.yml) So, we should keep supporting them. |
|
if you merge my pull request for levelgraph i can upgrade the levelgraph dependency and the build will be fixed. |
|
I've merged and released the levelgraph dep. |
|
Done but tests are now failing everywhere apart from v5. |
|
will test again today in the evening... oh... a dependency is missing |
2 participants
only had to change N3Util.isUrl() call to N3Util.isIRI()