-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds psalm and fixes first few findings #151
Conversation
psalm requires php 7.1 >= see https://github.com/vimeo/psalm/blob/master/docs/running_psalm/installation.md |
In the composer test script, testing with psalm takes a long time. We can make it faster for example if we only check changed files. maybe we should consider that. See command options with Command outputs:
|
We can consider automatic fixing just like phpcbf that they have built in. see https://github.com/vimeo/psalm/blob/master/docs/manipulating_code/fixing.md |
Versie van psalm die we hier gebruiken v3.2.12. Die zou nog wel compatible moeten zijn met 7.0, maar gezien de wijzigingen met de #152 kunnen we van 7.1 uitgaan. |
Risky for now. Let's make a ticket and explore this later. |
No description provided.