Fsd doc #1
Merged
Fsd doc #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft adding FSTD definition
Add FSD lateral melt
Added note on lateral growth
Adding floe size distribution references
|
Just noticed a typo in sg_itd.rst: ice_ice should probably be ice_init. |
lettie-roach
pushed a commit
that referenced
this pull request
Oct 18, 2022
* modifying PR template * updating PR template * adding link to documentation for PR (#1) * modifying PR template * typo * modifying wording * modifying link per PBsuggestion * adding second link * adding Tony's changes * typo * Making ECH suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving changes from FSD documentation branch into the fsd branch with the rest of the code changes, so that they can be combined into one PR for the Icepack master branch.
Developer(s):
Lettie Roach
Please suggest code Pull Request reviewers in the column at right.
Are the code changes bit for bit, different at roundoff level, or more substantial?
BFB
To verify that this PR passes the initial QC tests, please include the link to test results
or paste in below the summary block from the bottom of the testing output.
This will be tested as part of the PR into the master branch.
Does this PR create or have dependencies on CICE or any other models?
No
Is the documentation being updated with this PR? (Y/N). Yes
If not, does the documentation need to be updated separately at a later time? (Y/N)
The documentation will need to be checked as part of the master PR review.
Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.
I think this will work... should be easier than checking out the fsd branch and manually moving the changes! @lettie-roach if you'll review these PR changes and approve them, then either of us can do the merge.