Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: archival memory file upload #2228

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Conversation

mlong93
Copy link
Collaborator

@mlong93 mlong93 commented Dec 11, 2024

Please describe the purpose of this pull request.
When a user uploads a file to an existing source, archival memory is automatically updated to contain passages from that file.

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

Copy link

📦 Dependencies Alert:

  • poetry.lock has been modified

Please review these changes carefully to ensure they are intended (cc @sarahwooders @cpacker).

Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but I think there are some issues with loading multiple files in sequence that your tests aren't catching.

@mlong93 mlong93 merged commit 95fc4e7 into main Dec 12, 2024
36 checks passed
@mlong93 mlong93 deleted the mindy/archival-memory-file-upload branch December 12, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants