interior mutability pattern for UserStore concrete implementations #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: refactor UserStore add_user method signature to take an immutable reference to self, i.e. &self instead of &mut self,
moving the RwLock from UserStore trait into concrete implementations:
app_state.rs:
#[derive(Clone)]
pub struct UserStoreType(pub Arc<Box>);
hashmap_user_store.rs:
#[derive(Default)]
pub struct HashmapUserStore {
users: RwLock<HashMap<String, User>>,
}
See last commit: comprido96@1f7e79c#diff-afd280d500d88b598001a76068239f3fa07150812b4f0883d3ce73e697f8ef57