Skip to content

Comments

Display a Donorbox link if the iframe is blocked#2155

Open
jcjones wants to merge 3 commits intoletsencrypt:mainfrom
jcjones:donor-link-on-iframe-block
Open

Display a Donorbox link if the iframe is blocked#2155
jcjones wants to merge 3 commits intoletsencrypt:mainfrom
jcjones:donor-link-on-iframe-block

Conversation

@jcjones
Copy link
Contributor

@jcjones jcjones commented Feb 23, 2026

This is actually the opposite - it hides the link as soon as Donorbox's iframe loads, which should work more reliably. Maybe.

This is actually the opposite - it hides the link as soon as Donorbox's iframe loads, which should work more reliably. Maybe.
@jcjones
Copy link
Contributor Author

jcjones commented Feb 23, 2026

Fallback button: image

@jcjones jcjones marked this pull request as ready for review February 23, 2026 20:01
@jcjones jcjones marked this pull request as draft February 23, 2026 20:13
@jcjones
Copy link
Contributor Author

jcjones commented Feb 23, 2026

uBlock Origin still calls that onload but with an empty document, so I need to approach this differently.

jcjones added a commit to jcjones/website that referenced this pull request Feb 23, 2026
This is similar to letsencrypt/website#2155 but since MemorySafety only
hosts an iframe for matching, we do the matching here. This feels like it's not a great link,
but the non-`embed` URL is a 404, so I don't know a better link to use.
@jcjones jcjones marked this pull request as ready for review February 23, 2026 20:31
jcjones added a commit to jcjones/abetterinternet-website that referenced this pull request Feb 23, 2026
This a combination of letsencrypt/website#2155
and memorysafety/website#137 , with both a normal
DonorBox link and two instances of the "Check Company Matching..." buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant