Set WAIT 2 for all ALTER TABLE REORGANIZE PARTITION calls #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpherrinm
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
lgtm. Per the mariadb manual, wait 2 will wait to acquire locks for two seconds: https://mariadb.com/kb/en/wait-and-nowait/
Based on my reading of our metrics, this is an acceptable value. Longer waits are quite rare.
Do we need to add any extra error handling to partman to handle the new timeout errors we'll get?
|
We probably should, the MySQL command will return error, which is already accounted for, but the metrics wouldn't get updated. I've got an improvement, thanks @mcpherrinm! |
mcpherrinm
reviewed
Sep 13, 2022
|
|
||
| all_results = dict() | ||
| for table in conf.tables: | ||
| time_start = None |
There was a problem hiding this comment.
I was confused when reviewing but I see we set time_start to now on line 345; this is just to pull it into a higher scope
mcpherrinm
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.