ci: update golangci-lint to 2.13.1 - #8965
Draft
jsha wants to merge 3 commits into
Draft
Conversation
This has been deprecated for a while and is unused in prod.
jsha
force-pushed
the
update-golangci-lint
branch
from
August 21, 2026 20:06
113d77d to
4c654b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to get support for Go 1.27. In the process, some new lints were added and some old ones refined. This PR bumps golangci-lint and the corresponding boulder-tools image, along with fixing new lint findings.
One big theme: there were a bunch of findings for XSS, SSRF, or command injection via taint analysis. These were all spurious in the end: mostly local tools or tests. One case was in the WFE but is fine (the linter claimed XSS in output with Content-Type: application/json).
Removes deprecated SerialPrefix field (long since removed from prod configs).
Replaces manual encoding of an SCTList extension with a cryptobyte version (fixes a finding about casting integers to bytes).
Removes a few nolint annotations that are no longer needed.
In the SA tests, some
defers were not getting called: they called a function that returned a func, but did not invoke that func. Switched tot.Cleanup(), which expects a func and calls it at the appropriate time.