va: Preserve internal error in CAA check audit line - #8850
Merged
Conversation
On a failed local CAA check, the "CAA check result" audit line attached the internal error under blog.Error's "error" key, which the deferred logger also uses for the client-visible problem, producing duplicate keys in one JSON record. Parsers keep only one of the two values. Key the internal error as internalErr, matching the equivalent code in DoDCV.
beautifulentropy
changed the title
ezekiel
approved these changes
Jul 6, 2026
ezekiel
requested review from
a team and
aarongable
and removed request for
a team
July 6, 2026 19:30
aarongable
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a failed local CAA check, the "CAA check result" audit line attached the internal error under blog.Error's "error" key, which the deferred logger also uses for the client-visible problem, producing duplicate keys in one JSON record. Parsers keep only one of the two values. Key the internal error as internalErr, matching the equivalent code in DoDCV.
This PR was generated as part of an audit of #8606 using Claude Fable 5.