publisher: Log serials in hex - #8844
Merged
Merged
Conversation
blog.Serial documents that its argument should be the hex-encoded form, and every other call site uses core.SerialToString. This one logged the big.Int decimal form, which matches nothing else in the system when searching or joining on serial.
beautifulentropy
changed the title
aarongable
approved these changes
Jul 6, 2026
jsha
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blog.Serial documents that its argument should be the hex-encoded form, and every other call site uses core.SerialToString. This one logged the big.Int decimal form, which matches nothing else in the system when searching or joining on serial.
This PR was generated as part of an audit of #8606 using Claude Fable 5.