sa: add Limit field to CountFQDNSetsRequest #7887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
previously approved these changes
Dec 16, 2024
aarongable
requested review from
a team and
beautifulentropy
and removed request for
a team
jprenken
previously approved these changes
Dec 18, 2024
This allows us to replace FQDNSetExists with a call to FQDNSetTimestampsForWindow, with Limit set to 1. That, in turn, will allow us to log the time since issuance of the most recent certificate with a given FQDNSet.
jsha
force-pushed
the
add-limit-to-timestampsforwindow
branch
from
08b1b34 to
50c1372
Compare
|
(rebased to fix merge conflicts) |
aarongable
approved these changes
Dec 19, 2024
beautifulentropy
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to replace FQDNSetExists with a call to FQDNSetTimestampsForWindow, with Limit set to 1. That, in turn, will allow us to log the time since issuance of the most recent certificate with a given FQDNSet.