Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ra/ratelimits: Update tests, use new TransactionBuilder constructor, fix ARI rate limit exception #7869

Merged
merged 26 commits into from
Dec 18, 2024
Merged

ra/ratelimits: Update tests, use new TransactionBuilder constructor, fix ARI rate limit exception #7869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
be4f528
New TransactionBuilder constructor for pre-pop limits
jprenken Dec 4, 2024
9dd76d9
Use new LimitsConfig type
jprenken Dec 7, 2024
54f63fe
Not respectively
jprenken Dec 7, 2024
d4f4c9e
ra_test: Replace dummyRateLimitConfig with NewTransactionBuilder
jprenken Dec 7, 2024
063ae8c
Now there is substantially less mystery
jprenken Dec 7, 2024
89df713
Fix old rate limit names
jprenken Dec 9, 2024
f829912
Remove unused tests, fix new testing impl
jprenken Dec 9, 2024
bfcec46
Remove FIXME, test works
jprenken Dec 9, 2024
b7189f5
Address feedback
jprenken Dec 10, 2024
837a06b
Extensively address feedback
jprenken Dec 10, 2024
655ccfe
Rename test names for accuracy
jprenken Dec 10, 2024
8e82bf9
Merge branch 'main' of github.com:letsencrypt/boulder into newnewtxnb…
jprenken Dec 10, 2024
e572719
Merge branch 'main' of github.com:letsencrypt/boulder into newnewtxnb…
jprenken Dec 16, 2024
3d31655
Merge branch 'main' of github.com:letsencrypt/boulder into newnewtxnb…
jprenken Dec 16, 2024
da05bcb
Add a (failing) TestNewOrderRateLimits
jprenken Dec 16, 2024
a6af5a0
Fix test and bugs
jprenken Dec 17, 2024
6f35748
Merge branch 'main' of github.com:letsencrypt/boulder into newnewtxnb…
jprenken Dec 17, 2024
75602cf
Remove debug printf, fix comments, refactor isRenewal fix
jprenken Dec 17, 2024
2f2d535
Simplify test
jprenken Dec 17, 2024
f84819c
Really fix the test now
jprenken Dec 17, 2024
a37a419
More simplifications, remove FIXMEs
jprenken Dec 17, 2024
5753fee
Merge branch 'main' of github.com:letsencrypt/boulder into newnewtxnb…
jprenken Dec 18, 2024
5323e5b
Merge branch 'main' of github.com:letsencrypt/boulder into newnewtxnb…
jprenken Dec 18, 2024
eaec5ea
Address feedback: Except ARI renewals from all rate limits, not just …
jprenken Dec 18, 2024
67bd311
Address feedback
jprenken Dec 18, 2024
7a14391
Address feedback
jprenken Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/boulder-ra/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ func main() {
source := ratelimits.NewRedisSource(limiterRedis.Ring, clk, scope)
limiter, err = ratelimits.NewLimiter(clk, source, scope)
cmd.FailOnError(err, "Failed to create rate limiter")
txnBuilder, err = ratelimits.NewTransactionBuilder(c.RA.Limiter.Defaults, c.RA.Limiter.Overrides)
txnBuilder, err = ratelimits.NewTransactionBuilderFromFiles(c.RA.Limiter.Defaults, c.RA.Limiter.Overrides)
cmd.FailOnError(err, "Failed to create rate limits transaction builder")
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/boulder-wfe2/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ func main() {
source := ratelimits.NewRedisSource(limiterRedis.Ring, clk, stats)
limiter, err = ratelimits.NewLimiter(clk, source, stats)
cmd.FailOnError(err, "Failed to create rate limiter")
txnBuilder, err = ratelimits.NewTransactionBuilder(c.WFE.Limiter.Defaults, c.WFE.Limiter.Overrides)
txnBuilder, err = ratelimits.NewTransactionBuilderFromFiles(c.WFE.Limiter.Defaults, c.WFE.Limiter.Overrides)
cmd.FailOnError(err, "Failed to create rate limits transaction builder")
}

Expand Down
Loading
Loading