RA: pass through unpause requests to SA #7630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
requested review from
jsha and
beautifulentropy
and removed request for
jsha
beautifulentropy
previously approved these changes
Jul 25, 2024
beautifulentropy
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the RA's UnpauseAccount gRPC method forward the requested account ID to the SA's corresponding method, and in turn forward the SA's count of unpaused identifiers back to the caller in the response.
Changing the response message from emptypb.Empty to a new rapb.UnpauseAccountResponse is safe, because message names are not transmitted on the wire, only message field numbers.
While we're here, drastically simplify the wfe_test and sfe_test Mock RAs, so they don't have to implement methods that aren't actually used by the tests.
Fixes #7536