Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA: Pass requested new-order profile through to SA #7608

Merged
merged 2 commits into from
Jul 19, 2024
Merged

RA: Pass requested new-order profile through to SA #7608

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ffac4
RA: Pass requested new-order profile through to SA
aarongable Jul 17, 2024
01ddd0a
Stricter equality check
aarongable Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Stricter equality check
  • Loading branch information
@aarongable
aarongable committed Jul 19, 2024
commit 01ddd0a886a9cdac7588a8f9c0b4a0228741edf7
5 changes: 3 additions & 2 deletions ra/ra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2521,8 +2521,9 @@ func (ra *RegistrationAuthorityImpl) NewOrder(ctx context.Context, req *rapb.New
return nil, errIncompleteGRPCResponse
}

// Only re-use the order if the profile matches.
if newOrder.CertificateProfileName == "" || existingOrder.CertificateProfileName == newOrder.CertificateProfileName {
// Only re-use the order if the profile (even if it is just the empty
// string, leaving us to choose a default profile) matches.
if existingOrder.CertificateProfileName == newOrder.CertificateProfileName {
// Track how often we reuse an existing order and how old that order is.
ra.orderAges.WithLabelValues("NewOrder").Observe(ra.clk.Since(existingOrder.Created.AsTime()).Seconds())
return existingOrder, nil
Expand Down