Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: Switch to go-grpc-middleware/providers/prometheus #7588

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented Jul 11, 2024

While investigating #6384, I noticed that go-grpc-prometheus was deprecated last year and users should switch to go-grpc-middleware instead. The default prometheus histogram buckets will continue to be used and can be found here.

@pgporada pgporada requested a review from a team as a code owner July 11, 2024 17:14
@beautifulentropy
Copy link
Member

Ideally these two changes would be broken into two PRs but I think this is probably fine as well.

@pgporada
Copy link
Member Author

pgporada commented Jul 12, 2024

I see what you're saying, like make the switch using whatever the default buckets are and then the followup change would have been adding additional buckets. I considered that but thought it was such an inconsequential change and tacked it on here.

@pgporada pgporada requested a review from jsha July 12, 2024 14:42
@pgporada pgporada changed the title grpc: Specify grpc histogram buckets and switch to go-grpc-middleware/providers/prometheus grpc: Switch to go-grpc-middleware/providers/prometheus Jul 12, 2024
@pgporada pgporada merged commit 472effb into main Jul 12, 2024
12 checks passed
@pgporada pgporada deleted the use-non-deprecated-go-grpc-middleware-for-prometheus branch July 12, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants