dependencies: Update grpc-go from v1.64 to v1.64.1 #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
approved these changes
Jul 9, 2024
aarongable
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
It appears that the fix for https://pkg.go.dev/vuln/GO-2024-2978 is simply to remove the metadata struct's .String() method. This means that, instead of getting pretty-printed metadata, I think we'd just get a struct name and an address.
We don't have much control over this -- our code is simply a logging adaptor passed in to gRPC so that it can log whatever messages it wants. This just means that some of our gRPC failure log messages may end up slightly less helpful than before.
| @@ -73,6 +76,7 @@ func (pr *PkgDecoder) SyncMarkers() bool { return pr.sync } | |||
| func NewPkgDecoder(pkgPath, input string) PkgDecoder { | |||
| pr := PkgDecoder{ | |||
| pkgPath: pkgPath, | |||
| //aliases: aliases.Enabled(), | |||
There was a problem hiding this comment.
This line of diff is vaguely concerning to me. Is this not supposed to be commented out? Is this supposed to be followed-up with a TODO? I've asked upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.