Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update eggsampler/acme to support draft-ietf-acme-ari-03 #7470

Merged
merged 8 commits into from
May 8, 2024

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented May 2, 2024

Eggsampler/acme v3.6.0 has been released. I've updated the ARI integration tests to issue replacement orders.

Fixes #7463

@pgporada
Copy link
Member Author

pgporada commented May 2, 2024

Vendorcheck is failing because I added a replace block in the go.mod so I could easily test my changes from the in-progress eggsampler PR. That'll get resolved once the eggsampler PR is in good shape, merged, and a release is cut.

Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one optional suggestion and obviously waiting for eggsampler to be ready

test/integration/ari_test.go Outdated Show resolved Hide resolved
@pgporada pgporada marked this pull request as ready for review May 7, 2024 15:22
@pgporada pgporada requested a review from a team as a code owner May 7, 2024 15:22
aarongable
aarongable previously approved these changes May 7, 2024
test/integration/ari_test.go Show resolved Hide resolved
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
@pgporada pgporada merged commit 42b2240 into main May 8, 2024
12 checks passed
@pgporada pgporada deleted the may-i-offer-you-an-egg-in-these-trying-times branch May 8, 2024 15:01
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
…ncrypt#7470)

`Eggsampler/acme` v3.6.0 has been
[released](https://github.com/eggsampler/acme/releases/tag/v3.6.0). I've
updated the ARI integration tests to issue replacement orders.

Fixes letsencrypt#7463

---------

Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
AlinaADmi pushed a commit to plesk/boulder that referenced this pull request Jul 29, 2024
…ncrypt#7470)

`Eggsampler/acme` v3.6.0 has been
[released](https://github.com/eggsampler/acme/releases/tag/v3.6.0). I've
updated the ARI integration tests to issue replacement orders.

Fixes letsencrypt#7463

---------

Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ari-03 to eggsampler/acme to we can use it in integration tests
3 participants