Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: save hierarchy across runs #5729

Merged
merged 3 commits into from
Oct 21, 2021
Merged

integration: save hierarchy across runs #5729

merged 3 commits into from
Oct 21, 2021

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Oct 19, 2021

This allows repeated runs using the same hiearchy, and avoids spurious
errors from ocsp-updater saying "This CA doesn't have an issuer cert
with ID XXX"

Fixes #5721

jsha added 2 commits October 19, 2021 12:33
This allows repeated runs using the same hiearchy, and avoids spurious
errors from ocsp-updater saying "This CA doesn't have an issuer cert
with ID XXX"
@jsha jsha marked this pull request as ready for review October 19, 2021 22:17
@jsha jsha requested a review from a team as a code owner October 19, 2021 22:17
andygabby
andygabby previously approved these changes Oct 20, 2021
Copy link
Member

@andygabby andygabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

aarongable
aarongable previously approved these changes Oct 20, 2021
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

test/cert-ceremonies/generate.go Outdated Show resolved Hide resolved
@jsha jsha dismissed stale reviews from aarongable and andygabby via 54e87d1 October 20, 2021 22:27
@jsha jsha merged commit ba0ea09 into main Oct 21, 2021
@jsha jsha deleted the save-hierarchy branch October 21, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious errors running integration tests locally
4 participants