Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client package names for integration tests #1740

Merged
merged 2 commits into from
Apr 15, 2016
Merged

Update client package names for integration tests #1740

merged 2 commits into from
Apr 15, 2016

Conversation

bmw
Copy link
Contributor

@bmw bmw commented Apr 15, 2016

This should fix integration test failures. Sorry for the trouble!

@jsha
Copy link
Contributor

jsha commented Apr 15, 2016

This looks good as a quick fix. Is there something more robust we should be using? Like tools/venv.sh?

@jsha jsha merged commit e2e5e05 into letsencrypt:master Apr 15, 2016
@bmw
Copy link
Contributor Author

bmw commented Apr 15, 2016

Yes. tools/venv.sh is almost equivalent, except it installs our packages in editable mode (which shouldn't matter) and it always uses --python python2 when creating the venv.

If some of the systems you're testing on only have python2.7 available (I think OS X?), this won't work, however, we could modify our script to choose between python2/python2.7 based on what's in your PATH.

@bmw bmw deleted the client-rename branch April 15, 2016 19:22
@bmw bmw mentioned this pull request Apr 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
r=jsha r1=test-only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmw @jsha