Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RA.NewCertificate to not used named return values #3019

Closed
jsha opened this issue Aug 29, 2017 · 0 comments · Fixed by #3021
Closed

Fix RA.NewCertificate to not used named return values #3019

jsha opened this issue Aug 29, 2017 · 0 comments · Fixed by #3021

Comments

@jsha
Copy link
Contributor

jsha commented Aug 29, 2017

Will reduce risk of race conditions. Follow up from #3017.
@jsha jsha mentioned this issue Aug 29, 2017
Merged
jsha added a commit that referenced this issue Aug 30, 2017
@jsha
Remove all named returns from RA.
e1eb96d 
This is a followup from #3017, in
which we identified a data race caused by the use of named returns. This also
reverts the change from that PR, which was only a surface level fix.

Fixes #3019.
@jsha jsha mentioned this issue Aug 30, 2017
Merged
rolandshoemaker pushed a commit that referenced this issue Aug 30, 2017
@jsha
Remove all named returns from RA. (#3021)
ba95793 
This is a followup from #3017, in
which we identified a data race caused by the use of named returns. This also
reverts the change from that PR, which was only a surface level fix.

Fixes #3019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all named returns from RA. letsencrypt/boulder
1 participant
@jsha