Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Fix compiler warnings #4757

Merged
merged 10 commits into from
Aug 13, 2023
Merged

[Build] Fix compiler warnings #4757

merged 10 commits into from
Aug 13, 2023

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Aug 8, 2023 •
edited
Loading

Resolves some compiler warnings

  • [C018] Signed/unsigned comparison
  • [P146] Type difference size_t/int (also signed/unsigned comparison)
  • [Cache handler] Unused variables
  • [EasyColorCode] Fix some auto-complete issues and typos
  • [Docs] Fix some layout issues that caused parts of the documentation to 'disappear' (recently merged)

PVS Studio warnings:

  • [P122] Initialization moved from constructor to .h file
  • [P153] Remove unused variable

TODO:

  • [WebStaticData] useCDN conditionally unused variable skipped to avoid risks of breaking stuff
  • [P128] NeoPixelBus library fix deprecation warning: Deprecation warning disabled, newer methods won't properly work
    • Test on ESP8266
  • More testing

@TD-er TD-er merged commit 9297ac9 into letscontrolit:mega Aug 13, 2023
154 checks passed
@tonhuisman tonhuisman deleted the bugfix/Aug23-fix-compiler-warnings branch August 13, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TD-er TD-er TD-er left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonhuisman @TD-er