-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIFI] Fix mDNS startup for log levels below LOG_LEVEL_INFO #1980
Conversation
Can anyone test this? It would be a great addition but since I'm also struggling for 1MB builds to get them 2-step OTA again, it would be nice to know if the define to enable this should be 'common' or only on builds for larger flash chips. |
Hi @TD-er, I have checked patched mega-20181029 and it worked well, but now I applied patch to mega-20181031 and it doesn't work. :( I'm observing wdt reset just after AP connection is established.
I'll investigate it further. |
try to run task clean and rebuild one more time |
Tried clean/build, and it didn't help. But it looks like wdt resets are gone after I reverted back change from lwip ( |
Probably could be related to esp8266/Arduino#4028, but it seem it should be already fixed in esp8266/Arduino#4105. |
@3cky It is still before my first coffee of today, so it may be more obvious ;) Just to be sure, your problem was fixed when changing back from LWIP2/HB to LWIP1.4/HB? |
@TD-er exactly :) LWIP2/HB doesn't work, but LWIP1.4/HB works. I tried also LWIP2/low memory, it doesn't work either. |
Just tried to replace ESP8266mDNS library bundled with 2.4.2 by its previous versions. It seem last version of ESP8266mDNS library working with ESPEasy when LWIP2 is enabled is one bundled with 2.3.0, while 2.4.0 and later versions are crashing. |
Is there any update on this? |
Hi @TD-er, Sorry for the delay, still can't figure out why mDNS isn't working with 2.4.x for ESPEasy. I tried to build latest Sonoff-Tasmota (which also uses mDNS) with 2.4.2 and it seem to work fine. :( So I'm closing this PR for now and will open the new PR when this issue will be resolved. |
if (loglevelActiveFor(LOG_LEVEL_INFO)) { | ||
String log = F("WIFI : "); | ||
if (MDNS.begin(WifiGetHostname().c_str(), WiFi.localIP())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related to #2048 ??
it will not start if loglevel < INFO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No is not related to that issue, but indeed looks like a bug to me.
It seems #959 is almost here (still not enabled though), except small bug that prevents mDNS startup when log level is below LOG_LEVEL_INFO. This PR fixes this behaviour and also adds HTTP service to mDNS-SD registry.