[BUG][P076] calculation with multiplier values is broken

[chromoxdor]

Todays build with p076 causes it to display nonsense. (last used/working build ESP_Easy_mega_20220722)
Seems to be an issue with the calculation of the multiplier values.
If i use the same values as before or try the recalibrate with hlwcalibrate the output is not as expected.
e.g. with pure resistive load (80W): hlwcalibrate,228,0.352,80 ->

[chromoxdor]

Changes i found related to P076:

https://github.com/letscontrolit/ESPEasy/pull/4663/files#diff-7ec68dc04e4be4c0170970cfcd3ef1f88d6ab1cb1cd4edd87b325481315ab044

[TD-er]

A lot has been changed to that plugin since 20220722.
Does your unit have significantly different default multipliers compared to the used defaults in the code?

[chromoxdor]

Does your unit have significantly different default multipliers compared to the used defaults in the code?

I dont´t think so.
default:

calibrated:

[TD-er]

My voltage multiplier is 462022.94
I never calibrated the current/power on that node.

You could try to use the calibration command with only the voltage, just to see if that's working.

[chromoxdor]

You could try to use the calibration command with only the voltage, just to see if that's working.

It doesn´t

My voltage multiplier is 462022.94

I have around 8 devices here (all gosund sp1 or sp111)
They all have similar values and they definitely needed calibration...

[chromoxdor]

another issue is, that the command 'hlwcalibrate' doesn´t seem to work.. at least the values in the plugin do not change...

Edit: manually changing them works...

[TD-er]

Maybe there needs to be an actual floating point value?

Can you try

hlwcalibrate,228.0,0.352,80.0

[TD-er]

I think I see what may be happening here....
The function to apply calibration needs a proper last measurement value.
However it is somewhat of a trial-and-error to hit the command at just the right moment to get a proper _voltage value as this getVoltage function may every now and then return 0 as the reading is not yet ready.

[TD-er]

Made a fix for it, can you please test it?

[chromoxdor]

Command works! Sadly calculation is still wrong.....

The current value still doesn´t change

[TD-er]

"current" as in the last value, or the actual current as in amps?

[chromoxdor]

amps :)

[chromoxdor]

just realized that the power multiplier also doesn´t get changed.
So it´s only voltage that works.

It still is only "current" that doesn´t work 😬

[TD-er]

Just curious, what is the actual current being used the moment you try to perform the calibration?

Like if you tell the unit there is some load like 100 Watt, you really should have it present and the task already must have it measured.

So if you have the task interval set to 5 minutes and you apply some load, perform the calibration and disconnect the load, then it will fail as the measured current will still be 0.

[chromoxdor]

As always i use a 80w bulb, turn the plug on. See the measured values and enter the whole command (hlwcalibrate,228,0.352,80) if they differ from the real ones.
This sets on my old the devices the multipliers as expected.
(Even if i enter bogus values it changes the multipliers to my given values. This would be the expected behavior.)
Now it doesn´t set the current.
Not only the current multiplier doesn´t set but also the voltage multiplier seems to be based on something else. In the old build it would be e.g. 313103.87 now it is 164160.00 which is odd and would also mean, that even if the command will be fixed i have to recalibrate all my devices.

Edit: my taskinterval for that is always 1s

[TD-er]

Since this is already an older bug, it doesn't really make a difference whether I will fix it today or tomorrow (and you will be perfectly capable to make your own builds ;) )

Deadline for a fix for this one to be included in the November build is ~20h today.

[chromoxdor]

Since this is already an older bug, it doesn't really make a difference whether I will fix it today or tomorrow (and you will be perfectly capable to make your own builds ;) )

I am totally fine with that. Make your release first 🙂
But i have to ask if it would be ok for you not to wait too long with looking into it? Two of these power plugs i want to send to my brother as a present. Thats the only reason i updated these...
He has a photovoltaic system and does not necessarily want to feed the public power grid and use the excessive power for a heating. Thats why i also made the "thingspeakreply"-event. The power plug grabs the data from the inverter which is fed via a script to thingspeak and switches on and off a heater accordingly.

[chromoxdor]

I hope I'm not bothering you too much. This is just a little reminder :)

[TD-er]

I hope I'm not bothering you too much. This is just a little reminder :)

Makes me think about this Dutch commercial ;)

https://youtu.be/-c6zp7f9ZYw?t=25

[tonhuisman]

I hope I'm not bothering you too much. This is just a little reminder :)

Makes me think about this Dutch commercial ;)

https://youtu.be/-c6zp7f9ZYw?t=25

That's a real classic, I don't think the language is a problem here 😛 🤣

[chromoxdor]

Makes me think about this Dutch commercial ;)

🤣

That's a real classic, I don't think the language is a problem here 😛 🤣

definitely not...