Skip to content

Conversation

@SonarSoftware
Copy link
Contributor

Very minor change - I recently had a PR merged to fix a deprecation notice in Math_BigInteger, just updating the composer.json for this package to use the new version.

Does not change any functionality, just fixes the notice if using PHP7.

@SonarSoftware
Copy link
Contributor Author

Hmm, looks like this hasn't updated on packagist yet.

@tabacco
Copy link
Collaborator

tabacco commented Apr 12, 2016

I'm guessing they don't have any github hooks set up to notify packagist. You may have to open an issue with them to ask them to force a packagist update.

Edit: Actually, I'm writing up a bug for them now.
Edit 2: Opened https://pear.php.net/bugs/21053

@SonarSoftware
Copy link
Contributor Author

Cool, I was just about to do it - thanks!

@SonarSoftware
Copy link
Contributor Author

Looks like Packagist has been updated now!

@tabacco
Copy link
Collaborator

tabacco commented Apr 12, 2016

While you're at it, can you also add 7.0 to .travis.yml in your branch?

@SonarSoftware
Copy link
Contributor Author

Yep, just pushed.

@tabacco
Copy link
Collaborator

tabacco commented Apr 12, 2016

Thanks! I'll merge as soon as Travis finishes up.

@tabacco tabacco merged commit 1037cf7 into leth:master Apr 12, 2016
@tabacco
Copy link
Collaborator

tabacco commented Apr 12, 2016

..done and published in 1.1.1

Thanks for the fix!

@SonarSoftware
Copy link
Contributor Author

NP! I'd like to come back one of these days and replace BigInteger with phpseclib for better ongoing compatibility, but this should be good for now! Thanks for the great library, been very useful!

@tabacco
Copy link
Collaborator

tabacco commented Apr 12, 2016

I didn't write it, I just use it and happen to have commit access :)

@leth
Copy link
Owner

leth commented Apr 15, 2016

Thanks for looking after it :) I've not done any PHP in ages now and it's great to know it's still useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants