fix(issue#4354): unkown at-rule expression commas#4366
Closed
puckowski wants to merge 1 commit intoless:masterfrom
Closed
fix(issue#4354): unkown at-rule expression commas#4366puckowski wants to merge 1 commit intoless:masterfrom
puckowski wants to merge 1 commit intoless:masterfrom
Conversation
* Fix issue less#4354 unknown at-rule expressions should not have commas in keyword list.
3 tasks
|
This fix is very important for less. If it is not fixed, less will become incompatible with Tailwind's custom at-rules (such as @apply which relies on splitting the keywords after |
Member
|
It feels a little like a hack (as in-, why is Less assuming a list in the first place? That we then need to "override"?) But it's probably ok for now. (@puckowski can you add in some JSDoc stuff about how this is an odd behavior to begin with?) |
|
@puckowski @matthew-dean What's the status? Thanks! |
3 tasks
Contributor
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix issue #4354 unknown at-rule expressions should not have commas in keyword list.
Why:
Current behavior (4.4.0+):
Expected behavior:
There have been downstream issues, see: web-infra-dev/rsbuild#5688
Checklist:
Kept signature of
AtRulelargely the same to not introduce regressions.