Skip to content

fix(issue#4242): add support for layer at-rule #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion packages/less/src/less/parser/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -2065,6 +2065,7 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) {
let hasUnknown;
let hasBlock = true;
let isRooted = true;
let isKeywordList = false;

if (parserInput.currentChar() !== '@') { return; }

Expand Down Expand Up @@ -2105,6 +2106,9 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) {
case '@starting-style':
isRooted = false;
break;
case '@layer':
isRooted = false;
break;
default:
hasUnknown = true;
break;
Expand Down Expand Up @@ -2137,9 +2141,38 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) {

if (hasBlock) {
rules = this.blockRuleset();

parserInput.save();

if (!rules && !isRooted) {
value = this.entity();
rules = this.blockRuleset();
}

if (!rules && !isRooted) {
parserInput.restore();

let e = [];
value = this.entity();

while (parserInput.$char(',')) {
e.push(value);
value = this.entity();
}

if (value && e.length > 0) {
e.push(value);
value = e;
isKeywordList = true;
} else {
rules = this.blockRuleset();
}
} else {
parserInput.forget();
}
}

if (rules || (!hasBlock && value && parserInput.$char(';'))) {
if (rules || isKeywordList || (!hasBlock && value && parserInput.$char(';'))) {
parserInput.forget();
return new(tree.AtRule)(name, value, rules, index + currentIndex, fileInfo,
context.dumpLineNumbers ? getDebugInfo(index) : null,
Expand Down
13 changes: 12 additions & 1 deletion packages/less/src/less/tree/atrule.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ AtRule.prototype = Object.assign(new Node(), {
}
},

keywordList(rules) {
if (!Array.isArray(rules)) {
return false;
} else {
return rules.filter(function (node) { return (node.type === 'Keyword' || node.type === 'Comment'); }).length === rules.length;
}
},

accept(visitor) {
const value = this.value, rules = this.rules, declarations = this.declarations;

Expand Down Expand Up @@ -127,6 +135,9 @@ AtRule.prototype = Object.assign(new Node(), {

if (value) {
value = value.eval(context);
if (value.value && this.keywordList(value.value)) {
value = new Anonymous(value.value.map(keyword => keyword.value).join(', '), this.getIndex(), this.fileInfo());
}
}

if (rules) {
Expand All @@ -143,7 +154,7 @@ AtRule.prototype = Object.assign(new Node(), {
}
if (this.simpleBlock && rules) {
rules[0].functionRegistry = context.frames[0].functionRegistry.inherit();
rules= rules.map(function (rule) { return rule.eval(context); });
rules = rules.map(function (rule) { return rule.eval(context); });
}

// restore media bubbling information
Expand Down
66 changes: 66 additions & 0 deletions packages/test-data/css/_main/layer.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
@layer {
.main::before {
color: #f00;
}
}
@layer legacy {
.sub-rule ul {
color: white;
}
}
@layer primevue {
.test {
foo: bar;
}
}
@layer reset, base, components, utilities;
@layer reset {
*,
*::before,
*::after {
box-sizing: border-box;
}
}
@layer base {
body {
margin: 0;
font-family: system-ui, sans-serif;
}
body header {
background-color: #f0f0f0;
padding: 1rem;
}
}
@layer components {
.button {
display: inline-block;
padding: 0.5rem 1rem;
background-color: blue;
color: white;
}
.button:hover {
background-color: darkblue;
}
}
@layer utilities {
.text-center {
text-align: center;
}
.responsive {
width: 100%;
}
@media (min-width: 768px) {
.responsive {
width: 50%;
}
}
}
.parent {
color: black;
}
.parent .child {
color: red;
}
.parent:hover {
background: lightgray;
}
5 changes: 5 additions & 0 deletions packages/test-data/less/_main/import/layer-import.less
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.sub-rule {
ul {
color: white;
}
}
81 changes: 81 additions & 0 deletions packages/test-data/less/_main/layer.less
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
.main {
@layer {
&::before {
color: #f00;
}
}
}

@layer legacy {
@import "./import/layer-import.less";
}

@layer-name: primevue;

@layer @layer-name {
.test {
foo: bar;
}
}

@layer reset, base, components, utilities;

@layer reset {

*,
*::before,
*::after {
box-sizing: border-box;
}
}

@layer base {
body {
margin: 0;
font-family: system-ui, sans-serif;

header {
background-color: #f0f0f0;
padding: 1rem;
}
}
}

@layer components {
.button {
display: inline-block;
padding: 0.5rem 1rem;
background-color: blue;
color: white;

&:hover {
background-color: darkblue;
}
}
}

@layer utilities {
.text-center {
text-align: center;
}

.responsive {
width: 100%;

@media (min-width: 768px) {
width: 50%;
}
}
}

.parent {
color: black;

.child {
color: red;
}

&:hover {
background: lightgray;
}
}