Allow underscore in a dimension unit#2485
Merged
SomMeri merged 1 commit intoless:masterfrom Dec 7, 2015
seven-phases-max:allow-underscore-after-numbers
Merged
Allow underscore in a dimension unit#2485SomMeri merged 1 commit intoless:masterfrom seven-phases-max:allow-underscore-after-numbers
SomMeri merged 1 commit intoless:masterfrom
seven-phases-max:allow-underscore-after-numbers
Conversation
Member
|
Anyone objects if I merge this in? It makes less.js conform to css specification as stated here and less.js is supposed to be subset of css. The pull request seems harmless otherwise, it is just a small regexp change and nobody seems to object in associated issue discussion.. If nobody objects, I will merge this in next week. |
Member
|
Nope. Go for it. |
SomMeri
added a commit
that referenced
this pull request
Dec 7, 2015
…-numbers Allow underscore in a dimension unit
Krinkle
added a commit
to wikimedia/less.js
that referenced
this pull request
Oct 20, 2025
In Less.js 2.6.0, parsing of dimensions changed so that `5_large` is seen as one value, instead of as a list containing "5" and "_large". In updating the Less.php port, we forgot to consider this change because none of the Less.js 3.13 tests seem to cover this behavior. Follows-up less#2485. This adds the test case from less#2462, as inpired by downstream https://gerrit.wikimedia.org/r/1197310.
Krinkle
added a commit
to wikimedia/less.js
that referenced
this pull request
Oct 20, 2025
In Less.js 2.6.0, parsing of dimensions changed so that `5_large` is seen as one value, instead of as a list containing "5" and "_large". In updating the Less.php port, we forgot to consider this change because none of the Less.js 3.13 tests seem to cover this behavior. Follows-up less#2485. This adds the test case from less#2462, as inpired by downstream https://gerrit.wikimedia.org/r/1197310.
Krinkle
added a commit
to wikimedia/less.js
that referenced
this pull request
Oct 20, 2025
In Less.js 2.6.0, parsing of dimensions changed so that `5_large` is seen as one value, instead of as a list containing "5" and "_large". In updating the Less.php port, we forgot to consider this change because none of the Less.js 3.13 tests seem to cover this behavior. Follows-up less#2485. This adds the test case from less#2462, as inpired by downstream https://gerrit.wikimedia.org/r/1197310.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2462.