Conversation
tksugimoto
force-pushed
the
feature/akka-typed
branch
from
928fb4b to
0ab8832
Compare
tksugimoto
force-pushed
the
refactor/actor/failure-processing
branch
2 times, most recently
from
69696c6 to
65de78e
Compare
tksugimoto
force-pushed
the
feature/akka-typed
branch
2 times, most recently
from
7c51318 to
86f6953
Compare
tksugimoto
force-pushed
the
feature/akka-typed
branch
from
86f6953 to
20a63ff
Compare
8 tasks
tksugimoto
force-pushed
the
feature/akka-typed
branch
4 times, most recently
from
94ad97e to
8675a19
Compare
tksugimoto
changed the base branch from
main
to
chore/update-lerna-app-library/scala-test
tksugimoto
commented
Jun 8, 2021
...est/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActorSpec.scala
Outdated
Show resolved
Hide resolved
Base automatically changed from
chore/update-lerna-app-library/scala-test
to
main
June 9, 2021 00:30
tksugimoto
force-pushed
the
feature/akka-typed
branch
2 times, most recently
from
f3fb178 to
0c5f609
Compare
tksugimoto
commented
Jun 16, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActor.scala
Show resolved
Hide resolved
tksugimoto
force-pushed
the
feature/akka-typed
branch
from
0c5f609 to
56e5f78
Compare
typed 対応で StopMessage も Command にする必要があるため準備
typed 対応の準備
2箇所に近い記述があり冗長だったため
TODO: マルチテナント対応 (別 commit)
typed Actor の標準に合わせるため
Event の 抜け漏れ を compile 時に検知できるようにするため
tksugimoto
force-pushed
the
feature/akka-typed
branch
from
d859836 to
f392388
Compare
negokaz
reviewed
Jun 23, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActor.scala
Outdated
Show resolved
Hide resolved
negokaz
reviewed
Jun 23, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActor.scala
Outdated
Show resolved
Hide resolved
- デフォルトの HashCodeMessageExtractor を指定していた - number-of-shards は typed Cluster Sharding ならば conf から取得可能
Actor class 削除の準備
- test コードが冗長だった - Actor class 削除の準備
`def apply()` に移動
8 tasks
negokaz
reviewed
Jun 23, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActor.scala
Outdated
Show resolved
Hide resolved
negokaz
reviewed
Jun 24, 2021
negokaz
reviewed
Jun 24, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActor.scala
Outdated
Show resolved
Hide resolved
negokaz
reviewed
Jun 24, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActor.scala
Show resolved
Hide resolved
negokaz
reviewed
Jun 24, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/ecpayment/issuing/actor/PaymentActor.scala
Show resolved
Hide resolved
…るようにする Reply忘れがあるとcompileエラーになる ※ Replyが不要な場合は明示すればOK
無駄に括弧が多かった
negokaz
reviewed
Jun 24, 2021
...rc/main/scala/jp/co/tis/lerna/payment/application/util/tenant/actor/MultiTenantSupport.scala
Show resolved
Hide resolved
Contributor
|
マルチテナント化以外のドキュメント更新もしたほうが良いと思います。 例えば、次のドキュメントに lerna-sample-payment-app/ログ実装ガイド.md at feature/akka-typed · lerna-stack/lerna-sample-payment-app ライブラリ側にドキュメントがあるなら、重複する部分を消してリンクする形でも良いと思います。 |
Contributor
Author
classic Actor 用のコメントとなっていた
Contributor
|
@tksugimoto ActorSystem の Typed 化は別 PR で対応する予定でしょうか？
|
Contributor
Author
|
全体の typed ActorSystem は別PRです。 #30 |
意図と注意(気軽にコピーされないように)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaymentActorの typed 対応
TODO
レビューする際の注意
docs/projects/application/マルチテナント化されたClusterShardingの実装ガイド.mdrefactor: typed Actor 化 (Behavior)refactor: typed Actor 化 (マルチテナント対応)