Conversation
6b8ac63 to
84a233f
Compare
Contributor
|
@negokaz 特に確認してほしい点
|
negokaz
commented
Dec 15, 2021
app/entrypoint/src/main/scala/myapp/entrypoint/AppGuardian.scala
Outdated
Show resolved
Hide resolved
negokaz
commented
Dec 15, 2021
negokaz
commented
Dec 15, 2021
...ation/src/main/scala/myapp/application/util/healthcheck/JDBCHealthCheckServiceSettings.scala
Outdated
Show resolved
Hide resolved
negokaz
commented
Dec 20, 2021
...plication/src/test/scala/myapp/application/util/healthcheck/JDBCHealthCheckServiceSpec.scala
Outdated
Show resolved
Hide resolved
negokaz
commented
Dec 20, 2021
...plication/src/test/scala/myapp/application/util/healthcheck/JDBCHealthCheckServiceSpec.scala
Show resolved
Hide resolved
negokaz
commented
Dec 20, 2021
app/entrypoint/src/main/scala/myapp/entrypoint/AppGuardian.scala
Outdated
Show resolved
Hide resolved
negokaz
commented
Dec 20, 2021
app/application/src/main/scala/myapp/application/util/healthcheck/JDBCHealthCheck.scala
Outdated
Show resolved
Hide resolved
negokaz
commented
Dec 24, 2021
negokaz
commented
Dec 24, 2021
ydash
approved these changes
Dec 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
残り作業
JDBCHealthCheckを登録するJDBCHealthCheckServiceSettingsの実装