Skip to content

Comments

Reduce log outputs in tests of lerna-util-sequence#81

Merged
xirc merged 1 commit intomainfrom
add-logging-config-to-lerna-util-sequence-test
Jan 24, 2022
Merged

Reduce log outputs in tests of lerna-util-sequence#81
xirc merged 1 commit intomainfrom
add-logging-config-to-lerna-util-sequence-test

Conversation

@negokaz
Copy link
Contributor

@negokaz negokaz commented Jan 24, 2022

The debug log outputs from com.datastax.oss.driver makes us difficult to read the log from lerna.util.sequence.

(It was affected by the change in #78)

For example:

12:06:41.605 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-11] INFO lerna.util.sequence.SequenceFactoryWorker$ - initial reserved: max:91, initial:1
12:06:41.605 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-11] DEBUG lerna.util.sequence.SequenceFactoryWorker$ - SequenceGenerated: 1
12:06:41.608 [s14-io-3] DEBUG com.datastax.oss.driver.internal.core.channel.InFlightHandler - [s14|id: 0xd825ec7d, L:/127.0.0.1:50400 - R:/127.0.0.1:9042] Got last response on in-flight stream id 0, completing and releasing
12:06:41.611 [s14-io-3] DEBUG com.datastax.oss.driver.internal.core.channel.InFlightHandler - [s14|id: 0xd825ec7d, L:/127.0.0.1:50400 - R:/127.0.0.1:9042] Got last response on in-flight stream id 0, completing and releasing
12:06:41.611 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-11] INFO lerna.util.sequence.SequenceStore$ - Reserved > sequenceId: 568e4087-2d88-4769-9036-a981c084dbbb  sequenceSubId: test-29  nodeId: 1  reservedValue: 91
12:06:41.612 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-13] INFO lerna.util.sequence.SequenceFactoryWorker$ - initial reserved: max:91, initial:1
12:06:41.612 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-13] DEBUG lerna.util.sequence.SequenceFactoryWorker$ - SequenceGenerated: 1
12:06:41.616 [s14-io-3] DEBUG com.datastax.oss.driver.internal.core.channel.InFlightHandler - [s14|id: 0xd825ec7d, L:/127.0.0.1:50400 - R:/127.0.0.1:9042] Got last response on in-flight stream id 0, completing and releasing
12:06:41.623 [s14-io-3] DEBUG com.datastax.oss.driver.internal.core.channel.InFlightHandler - [s14|id: 0xd825ec7d, L:/127.0.0.1:50400 - R:/127.0.0.1:9042] Got last response on in-flight stream id 0, completing and releasing
12:06:41.623 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-11] INFO lerna.util.sequence.SequenceStore$ - Reserved > sequenceId: 568e4087-2d88-4769-9036-a981c084dbbb  sequenceSubId: test-30  nodeId: 1  reservedValue: 91
12:06:41.624 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-13] INFO lerna.util.sequence.SequenceFactoryWorker$ - initial reserved: max:91, initial:1
12:06:41.624 [CassandraSequenceFactorySpec-akka.actor.default-dispatcher-13] DEBUG lerna.util.sequence.SequenceFactoryWorker$ - SequenceGenerated: 1
12:06:41.628 [s14-io-3] DEBUG com.datastax.oss.driver.internal.core.channel.InFlightHandler - [s14|id: 0xd825ec7d, L:/127.0.0.1:50400 - R:/127.0.0.1:9042] Got last response on in-flight stream id 0, completing and releasing
12:06:41.632 [s14-io-3] DEBUG com.datastax.oss.driver.internal.core.channel.InFlightHandler - [s14|id: 0xd825ec7d, L:/127.0.0.1:50400 - R:/127.0.0.1:9042] Got last response on in-flight stream id 0, completing and releasing

This change will not affect users.

@negokaz negokaz changed the title 👷chore: Reduce log outputs in test Reduce log outputs in tests of lerna-util-sequence Jan 24, 2022
@xirc xirc self-requested a review January 24, 2022 04:27
Copy link
Contributor

@xirc xirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xirc xirc merged commit ca3f2b2 into main Jan 24, 2022
@xirc xirc deleted the add-logging-config-to-lerna-util-sequence-test branch January 24, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants