SequenceFactoryWorker が SequenceStore から応答を受けたときの振る舞いのテストケースを検討する#63
Merged
tksugimoto merged 9 commits intofeature/fix-sequence-factoryfrom Oct 15, 2021
Merged
Conversation
negokaz
force-pushed
the
sequence-factory-worker-store-reply-pict
branch
from
157bdee to
dc4db32
Compare
negokaz
changed the title
negokaz
force-pushed
the
improve-sequence-factory-pict
branch
from
90bcbff to
ddf5d3a
Compare
negokaz
force-pushed
the
sequence-factory-worker-store-reply-pict
branch
from
dc4db32 to
3472f66
Compare
negokaz
force-pushed
the
sequence-factory-worker-store-reply-pict
branch
from
3472f66 to
579ec2d
Compare
negokaz
force-pushed
the
improve-sequence-factory-pict
branch
from
fb08704 to
2e7f172
Compare
negokaz
force-pushed
the
sequence-factory-worker-store-reply-pict
branch
from
579ec2d to
b99060c
Compare
Base automatically changed from
improve-sequence-factory-pict
to
sequence-factory-worker-generate-pict
September 24, 2021 07:01
isStarving, generated.isStarving, generated.isOverflow, @採番値予約, @採番値リセット が不要になりました。 リトライ部分は処理ロジック的にはリスクを感じるほど複雑ではないため、コードレビュー + 既存のテストケースでカバーします
tksugimoto
reviewed
Sep 28, 2021
...a-util-sequence/src/test/resources/test-cases/picts/sequence_factory_worker_store_reply.pict
Outdated
Show resolved
Hide resolved
tksugimoto
reviewed
Sep 28, 2021
...a-util-sequence/src/test/resources/test-cases/picts/sequence_factory_worker_store_reply.pict
Outdated
Show resolved
Hide resolved
@received.isEmpty は Store からのリプライを受けた直後であり、採番の有無による影響を受けないため
No isEmpty isOverflow msg msg.maxReservedValue @received.isEmpty 14 TRUE TRUE SequenceReset = ctx.maxReservedValue FALSE のケースでも採番できるのが仕様としては望ましいことがわかった
negokaz
force-pushed
the
sequence-factory-worker-store-reply-pict
branch
from
a0ff65d to
2a8a3a9
Compare
Base automatically changed from
sequence-factory-worker-generate-pict
to
feature/fix-sequence-factory
October 15, 2021 07:33
…rker-store-reply-pict
tksugimoto
approved these changes
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
次の指摘をきっかけに作成しました： #57 (comment)
次のケースが指摘で示されたシナリオに対応します。
次の PR の修正に依存しています