Merged
Conversation
tksugimoto
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"com.github.tomakehurst" % "wiremock-jre8" % "2.30.1"に更新します。wiremock/wiremock@2.27.2...2.30.1 から差分を確認できます。
多くの更新が含まれており、すべてを確認するのは難しいですが、
必要な機能の unit test が実施されているため、更新によって問題は発生しないと思われます。
https://github.com/lerna-stack/lerna-app-library/blob/v2.0.0/lerna-testkit/src/test/scala/lerna/testkit/wiremock/ExternalServiceMockSpec.scala
WireMock は Guava に依存しています。次の URL から確認できます。
https://github.com/tomakehurst/wiremock/blob/2.27.2/build.gradle#L40-L57
Guava にはいくつかの脆弱性が報告されています。
CVE - CVE-2018-10237
CVE - CVE-2020-8908
WireMock は脆弱性に該当する機能を使っていないようですが、可能な限り最新版を使うほうが良いでしょう。
WireMock 2.30.1 にすることで、 Guava '30.1.1-jre' まで更新することができます。
https://github.com/tomakehurst/wiremock/blob/2.30.1/build.gradle#L26-L32
※ Guava を最新版にするためには、#54 で対応する DataStax Java Driver の更新も必要です。