Conversation
tksugimoto
commented
Jun 11, 2021
...-sequence/src/main/mima-filters/1.0.0.backwards.excludes/29-typed-support.backwards.excludes
Show resolved
Hide resolved
tksugimoto
force-pushed
the
typed/lerna-util-sequence
branch
4 times, most recently
from
77e015c to
71f6620
Compare
※ 現時点では落ちる > java.lang.UnsupportedOperationException: cannot create top-level actor [SequenceFactory-29550e6c-e546-4593-912c-43bba3a0c663-dummy] from the outside on ActorSystem with custom user guardian
tksugimoto
force-pushed
the
typed/lerna-util-sequence
branch
3 times, most recently
from
f93a4b3 to
a0c8c6c
Compare
原因 > java.lang.UnsupportedOperationException: cannot create top-level actor from the outside on ActorSystem with custom user guardian Actor の定義を typed に変更し、 system.actorOf を 使用しないように変更
デフォルト restart であるため。 typed 化によって exception のログ出力がなくなったため差異がなくなった
tksugimoto
force-pushed
the
typed/lerna-util-sequence
branch
from
a0c8c6c to
f285801
Compare
tksugimoto
commented
Jun 15, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceFactorySupervisor.scala
Show resolved
Hide resolved
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceFactoryWorker.scala
Show resolved
Hide resolved
lerna-util-sequence/src/test/scala/lerna/util/sequence/SequenceStoreSpec.scala
Show resolved
Hide resolved
negokaz
reviewed
Jun 18, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceFactorySupervisor.scala
Outdated
Show resolved
Hide resolved
negokaz
reviewed
Jun 18, 2021
This reverts commit cc41961. 設計意図（その例外が起きたときにどう対処すべきなのか）を示す目的で消さずに残しておく
negokaz
reviewed
Jun 18, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/CassandraSequenceFactory.scala
Outdated
Show resolved
Hide resolved
negokaz
reviewed
Jun 18, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceFactorySupervisor.scala
Outdated
Show resolved
Hide resolved
Akka が提供するAPIなのでより適切
negokaz
reviewed
Jun 18, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceStore.scala
Show resolved
Hide resolved
negokaz
reviewed
Jun 18, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceFactoryWorker.scala
Show resolved
Hide resolved
negokaz
reviewed
Jun 18, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceFactoryWorker.scala
Show resolved
Hide resolved
negokaz
reviewed
Jun 18, 2021
lerna-util-sequence/src/main/scala/lerna/util/sequence/SequenceFactoryWorker.scala
Outdated
Show resolved
Hide resolved
Akka ドキュメントで使用されている Behavior に可能な限り統一
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11
v2.0.0 · Issue #11 · lerna-stack/lerna-app-library変更内容
val system: ActorSystem->val system: ClassicActorSystemProvider参考
Behaviors.withStash()context.messageAdaptercopysourceBehaviors.supervise(behavior).onFailure[type](???)関連する問題
#24
typed ActorSystem を new して使うと一部モジュールでエラー · Issue #24 · lerna-stack/lerna-app-libraryを選択した。
Extension化は テナント情報
def supportedTenants: Seq[Tenant]をコンストラクタに渡すことができないため、不可このPRで修正しない既存の改善点/問題
Initializeが不要SequenceStore.ReservationFailedの handling 漏れCommandはNoSerializationVerificationNeededを継承したほうが良いOpenSessionが不要final case object ReservationFailed extends RuntimeExceptionのRuntimeExceptionが不要Issue にしました。
#35
lerna-util-sequence 改善 · Issue #35 · lerna-stack/lerna-app-library