Skip to content

Enable MiMa binary compatibility check of rollback-tool-cassandra #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2023
Merged

Enable MiMa binary compatibility check of rollback-tool-cassandra #205

merged 2 commits into from
May 8, 2023

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Apr 28, 2023 •
edited
Loading

Enable MiMa binary compatibiltiy check of akka-entity-replication-rollback-tool-cassandra.

There is one potential problem, which is from #203 :

https://github.com/lerna-stack/akka-entity-replication/actions/runs/4829005367/jobs/8603518330?pr=205

Error:  akka-entity-replication-rollback-tool-cassandra: Failed binary compatibility check against com.lerna-stack:akka-entity-replication-rollback-tool-cassandra_2.13:2.2.0! Found 1 potential problems
Error:   * method deleteTagView(java.lang.String)scala.concurrent.Future in class lerna.akka.entityreplication.rollback.cassandra.CassandraPersistentActorRollback does not have a correspondent in current version
Error:     filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("lerna.akka.entityreplication.rollback.cassandra.CassandraPersistentActorRollback.deleteTagView")
Error:  java.lang.RuntimeException: Failed binary compatibility check against com.lerna-stack:akka-entity-replication-rollback-tool-cassandra_2.13:2.2.0! Found 1 potential problems

It can be filtered since class CassandraPersistentActorRollback is private:

@xirc xirc changed the title WIP: Enable MiMa binary compatibility check WIP: Enable MiMa binary compatibility check of rollback-tool-cassandra Apr 28, 2023
@xirc xirc changed the title WIP: Enable MiMa binary compatibility check of rollback-tool-cassandra Enable MiMa binary compatibility check of rollback-tool-cassandra May 8, 2023
@xirc xirc marked this pull request as ready for review May 8, 2023 06:18
@xirc xirc requested a review from negokaz May 8, 2023 06:19
negokaz
negokaz approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@negokaz negokaz merged commit a2a7b0f into master May 8, 2023
@negokaz negokaz deleted the enable-mima-binary-compatibility-check-of-rollback-tool-cassandra branch May 8, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz