-
-
Notifications
You must be signed in to change notification settings - Fork 795
Replace vendored wasm-split with out-of-repository version #4369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
currently a git dependency, must be fixed before merge
My feedback on the test. During the wasm compilation I see warnings on the trait:
The error I get in my project is:
Edit, in Chrome I get a better error:
I'll share a zip of the output in Discord. |
6be4199
to
e170230
Compare
@johansmitsnl if you have time, I'd value your test on the newest updated version of both this branch paired with the |
@WorldSEnder I did a quick test and it is working with a debug build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, with the crate-name caveat noted above.
tachys = { path = "./tachys", version = "0.2.9" } | ||
wasm_split_helpers = { path = "./wasm_split", version = "0.1.2" } | ||
wasm_split_macros = { path = "./wasm_split_macros", version = "0.1.3" } | ||
wasm_split = { git = "https://github.com/WorldSEnder/wasm-split-prototype.git", version = "0.1", rev = "58a1687f830b87418e6e55fcdbb68c2fbee639f8" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: you're not going to be able to publish this as wasm_split
due to a 6 year old name-squat. But I'm happy to give shared ownership of wasm_split_helpers
if we're going to use the same crate anyway.
PR is for testing for now. The git dependency must be replaced by a proper release of the
wasm-split
crate before merging.To be used in tandem with the PR on
cargo-leptos
in leptos-rs/cargo-leptos#578