-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option<T> read-like traits & deprecate MaybeSignal/MaybeProp #3098
base: main
Are you sure you want to change the base?
Conversation
So, this is objectively nice, and a good idea to implement the traits on I'd note that it's different from I'd like to review in a little more depth. It also seems there is some overlapping code between this and the other PR, which led to a merge issue after I merged the other one, and also some duplicate code to review... Would you mind fixing the merge issues? Then I'll take a look again. |
23b4f4c
to
d9d248f
Compare
d9d248f
to
46c615c
Compare
7bd3046
to
75fcf63
Compare
Fixed conflicts! You're right I was forgetting
Aside from the non
|
But to be clear I have no issue getting rid of the deprecations by the way! As you've seen over the last few PR's I've done, my main goal is to "elevate" top-level |
Got
^😍Option<T>
working to automatically implement read-like traits for anyT
implementing read-like traits, soMaybeProp
but generic for allRwSignal
,Memo
,Signal
... etc.I think my changes across the last few PR's now meet the requirements to deprecate
MaybeSignal
andMaybeProp
but that's up to you.This PR depends on #3076, so this shouldn't be merged until after that's finished with and merged.
The only actual change in this PR is the new
trait_options.rs
file, everything else is changes from the unmerged #3076 or deprecation stuff. Edit: and some moreFrom<>
impls forSignal
.I could implement
Write
-like traits too, wouldn't be hard, each op would just be a noop whenNone
, but maybe this is too weird.