Skip to content

feat(controls): Implement SpinButtonPlacementMode.Compact for NumberBox - #1709

Merged
pomianowski merged 5 commits into
lepoco:mainfrom
chucker:feature/number-box/compact-spin-button
May 4, 2026
Merged

feat(controls): Implement SpinButtonPlacementMode.Compact for NumberBox#1709
pomianowski merged 5 commits into
lepoco:mainfrom
chucker:feature/number-box/compact-spin-button

Conversation

@chucker

@chucker chucker commented May 3, 2026

Copy link
Copy Markdown
Collaborator

NumberBox already had a SpinButtonPlacementMode.Compact; however, it previously had the same effect as Hidden. This adds a style to NumberBox that will:

  • add a button with an up/down symbol:
image
  • when clicked, pop out a flyout, with buttons to increment/decrement:
image

It also expands Gallery's NumberBoxPage to let users try out the three variants.

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: fixes #1673

What is the new behavior?

SpinButtonPlacementMode.Compact now has its own look/behavior.

Other information

The result roughly matches the look+feel in WinUI 3 Gallery 2.9.0.0:

image image

Minor differences:

  • there's no Flyout drop shadow (see Flyout should have a drop shadow #1708)
  • the buttons should probably have the "subtle" style, which I don't believe WPF UI implements; from the WinUI gallery:
image

@chucker
chucker requested a review from pomianowski as a code owner May 3, 2026 16:32
@github-actions github-actions Bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request gallery WPF UI Gallery dotnet release labels May 3, 2026
@chucker chucker mentioned this pull request May 3, 2026
Closed
1 task done
@pomianowski pomianowski changed the title Implement SpinButtonPlacementMode.Compact for NumberBox feat(controls): Implement 'SpinButtonPlacementMode.Compact' for NumberBox May 3, 2026
@stanlrt

stanlrt commented May 3, 2026

Copy link
Copy Markdown

Thanks for doing it, in the end i never found the time

@pomianowski pomianowski changed the title feat(controls): Implement 'SpinButtonPlacementMode.Compact' for NumberBox feat(controls): Implement SpinButtonPlacementMode.Compact for NumberBox May 4, 2026
@pomianowski
pomianowski merged commit 5922459 into lepoco:main May 4, 2026
2 checks passed
@chucker
chucker deleted the feature/number-box/compact-spin-button branch May 4, 2026 08:01
This was referenced May 4, 2026
Merged
Closed
Merged
Open
Closed
Merged
This was referenced May 11, 2026
Open
Closed
This was referenced May 25, 2026
Closed
Closed
Merged
This was referenced Jun 1, 2026
Closed
Closed
Open
This was referenced Jun 15, 2026
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jun 29, 2026
Closed
This was referenced Jul 6, 2026
Closed
Open
Closed
Merged
axiomoth pushed a commit to splrad/LayerScape that referenced this pull request Jul 9, 2026
@dependabot
chore(nuget): Bump System.Management, System.ValueTuple and WPF-UI (#112
14f0506 
)

Updated [System.Management](https://github.com/dotnet/dotnet) from
10.0.7 to 10.0.9.

<details>
<summary>Release notes</summary>

_Sourced from [System.Management's
releases](https://github.com/dotnet/dotnet/releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/dotnet/dotnet/commits).
</details>

Updated
[System.ValueTuple](https://github.com/dotnet/maintenance-packages) from
4.5.0 to 4.6.2.

<details>
<summary>Release notes</summary>

_Sourced from [System.ValueTuple's
releases](https://github.com/dotnet/maintenance-packages/releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/dotnet/maintenance-packages/commits).
</details>

Updated [WPF-UI](https://github.com/lepoco/wpfui) from 4.2.1 to 4.3.0.

<details>
<summary>Release notes</summary>

_Sourced from [WPF-UI's
releases](https://github.com/lepoco/wpfui/releases)._

## 4.3.0

## What's Changed
* fix(controls): Add UpdateAutoSuggestBoxSuggestions call on
MenuItemCollection change by @​scanfing in
lepoco/wpfui#1696
* fix(tray): support Unicode for NotifyIcon.TooltipText by @​chucker in
lepoco/wpfui#1706
* feat(controls): Implement `SpinButtonPlacementMode.Compact` for
`NumberBox` by @​chucker in lepoco/wpfui#1709
* fix(controls): Change order of triggers for Button by @​dkuaf in
lepoco/wpfui#1702


**Full Changelog**:
lepoco/wpfui@4.2.1...4.3.0

Commits viewable in [compare
view](lepoco/wpfui@4.2.1...4.3.0).
</details>

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot dependabot Bot mentioned this pull request Jul 13, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 20, 2026
Closed
This was referenced Aug 4, 2026
Closed
Closed
This was referenced Aug 18, 2026
Closed
Merged
Merged
Merged
@dependabot dependabot Bot mentioned this pull request Aug 27, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Sep 15, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Sep 27, 2026
Open
@dependabot dependabot Bot mentioned this pull request Oct 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees

No one assigned

Labels

controls Changes to the appearance or logic of custom controls. dotnet gallery WPF UI Gallery PR Pull request release styles Topic is related to styles

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NumberBox's SpinButtonPlacementMode="Compact" behaves like "Hidden"

3 participants

@chucker @stanlrt @pomianowski