Fix DatePicker focus #1516
Open
Fix DatePicker focus #1516
+141
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
|
Depends on #1472. |
|
With some converters we can still get a proper focus style of the textbox. 
Updated the PR. Using TAB still works now, which is nice improvement over the original version. |
chucker
approved these changes
Aug 24, 2025
|
We can actually make it much simpler now by just reusing the default TextBox style. This also fixes the darker focus border at the bottom as shown in the above screenshot (which is what I wanted to investigate in the first place). 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
This focus looks ugly (accent border goes through the side and it doesn't cover the entire picker), and as DatePicker doesn't seem to have a working FocusVisualStyle, remove the focus style there completely, and allow the user to go to the calendar button with TAB as well (this now DOES focus).
I also fixed the missing dropshadow for calender picker:
