AutomationProperties property not found on object of type MenuItem ( After updating to v4.0.0)

[LucaSamarCMA]

Describe the bug

I get this exception after updating to the new release. I don't have this problem with version 4.0.0-rc.3

System.Windows.Data Error: 40 : BindingExpression path error: 'AutomationProperties' property not found on 'object' ''MenuItem' (Name='')'. BindingExpression:Path=AutomationProperties.Name; DataItem='MenuItem' (Name=''); target element is 'TextBlock' (Name=''); target property is 'Text' (type 'String')

To Reproduce

Open the MenuItem

Expected behavior

don't get any xaml error

Screenshots

OS version

Windows 11

.NET version

net9

WPF-UI NuGet version

4.0.0

Additional context

No response

[snt0]

I seem to get this issue when I am creating MenuItems in an ItemsControl.

[timliucode]

Hi, I encountered the same issue in ui:DropDownButton when using MenuItem.
Additionally, I downloaded and compiled the source code, then ran the WPFUI Gallery, and the same error occurred.

OS version
Windows 11 24H2

.NET version
net8

WPF-UI NuGet version
4.0.0

[JohnTasler]

Yes, I just noticed this, too. I found the source of the problem, and I'll submit a PR to fix it.

[LucaSamarCMA]

Hi John, thanks for your help!
I downloaded the code from your fork and I’m no longer seeing the XAML error.
However, it’s still not working as expected. When I click on an item, the menu closes eventhough "StaysOpenOnClick" is set to True, and the corresponding action isn’t triggered

[JohnTasler]

I'll take a look at that, since I already have a PR for the Binding issues.

Can you provide a ZIP'ed up repro project?

[snt0]

When I click on an item, the menu closes eventhough "StaysOpenOnClick" is set to True, and the corresponding action isn’t triggered

I haven't got time to test right now, but I think I fixed an issue with command bindings not working on sub-menu items by settings the TextBlock IsHitTestVisible property (on the newly-added TextBlock that contains the AutomationProperties.Name text) to false.

[LucaSamarCMA]

WpfApp1.zip

I created a simple solution where you can easily replicate the issue with the version downloaded from your fork @JohnTasler

[LucaSamarCMA]

If I revert to the version of menuitem.xaml from before this commit, I no longer experience the issue
JohnTasler@e55d7d7

[JohnTasler]

@Difegue, I have a question about the initial change you made to the MenuItem templates. The comment says:

<!-- TextBlock added so that screen readers don't try to read Icon -->

What screen reader have you discovered that is reading the Icon content? I just tried Windows 11's built-in Narrator, and even without this TextBlock added, it does not read anything I put in the MenuItem.Icon property. I've tried both a SymbolIcon and just text. Narrator does not read it.

[Difegue]

I believe that was with the Windows narrator, although I recall the fix was initially needed for both Button and MenuItem -- We noticed at a later point the workaround wasn't needed for Buttons anymore (likely due to a Windows narrator update?), so I removed it from the PR.

Maybe MenuItem actually was fixed in the same way?

[JohnTasler]

It seems that it was. Do you happen to have the commit of the Button change. It was likely in your fork before the PR.

I will update my PR to remove the unnecessary TextBlock element.

I may also try it on Windows 10, using a VM.

[Difegue]

Sure thing, I believe that's the one.