Skip to content

Commit

Permalink
Merge pull request Lightricks#7 from Lightricks/feature/sample_parameter
Browse files Browse the repository at this point in the history
registry: Allow the caller to pass the sample.
  • Loading branch information
dgilboa authored Sep 30, 2020
2 parents e9dcf06 + 469b4b6 commit e162084
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions pyformance/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def meter(self, key, tags=None):
def create_sink(self):
return None

def timer(self, key, tags=None):
def timer(self, key, tags=None, sample=None):
"""
Gets a timer based on a key, creates a new one if it does not exist.
Expand All @@ -136,6 +136,9 @@ def timer(self, key, tags=None):
:param tags: tags attached to the timer (e.g. {'region': 'us-west-1'})
:type tags: C{dict}
:param sample: a sample manager, default is ExpDecayingSample
:type sample: L{Object}
:return: L{Timer}
"""
metric_key = BaseMetric(key, tags)
Expand All @@ -144,7 +147,8 @@ def timer(self, key, tags=None):
key=key,
clock=self._clock,
sink=self.create_sink(),
tags=tags
tags=tags,
sample=sample,
)
return self._timers[metric_key]

Expand Down Expand Up @@ -338,8 +342,8 @@ def _get_key(self, key):
key = "/".join((v for match in matches for v in match.groups() if v))
return key

def timer(self, key, tags=None):
return super(RegexRegistry, self).timer(key=self._get_key(key), tags=tags)
def timer(self, key, tags=None, sample=None):
return super(RegexRegistry, self).timer(key=self._get_key(key), tags=tags, sample=sample)

def histogram(self, key, tags=None):
return super(RegexRegistry, self).histogram(key=self._get_key(key), tags=tags)
Expand Down Expand Up @@ -383,8 +387,8 @@ def meter(key, tags=None):
return _global_registry.meter(key, tags)


def timer(key, tags=None):
return _global_registry.timer(key, tags)
def timer(key, tags=None, sample=None):
return _global_registry.timer(key, tags, sample=sample)


def event(key, tags=None):
Expand Down

0 comments on commit e162084

Please sign in to comment.