Add support for the "loudness" block and "loudness greater than" trigger#137
Merged
adroitwhiz merged 8 commits intoleopard-js:masterfrom Jul 24, 2022
Merged
Add support for the "loudness" block and "loudness greater than" trigger#137adroitwhiz merged 8 commits intoleopard-js:masterfrom
adroitwhiz merged 8 commits intoleopard-js:masterfrom
Conversation
Collaborator
Collaborator
|
I am confused... I changed nothing, but an hour later, Edit: Aaaaaannnd now it's broken again. |
Collaborator
|
Oh, I see. Chrome has been giving me the following warning for a long time now (since long before this PR): I assumed this was for playing sounds only, but it appears that the microphone access also relies on |
PullJosh
reviewed
Jul 22, 2022
Only try to connect if we're in the "never tried to connect" state.
PullJosh
approved these changes
Jul 24, 2022
Collaborator
There was a problem hiding this comment.
Behavior looks good now 👍
(@towerofnix said they might be away, so I removed them as a reviewer.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Based on @apple502j's work, with some refactoring and rebasing to work with the new edge-activated trigger code and also clean up the code a bit.
Resolves #122 and closes #60.