[Dubbo-4140] Fix the related test case for fixing (apache#4101).

leonliao · May 24, 2019 · 3e1e470 · 3e1e470
1 parent 0b812c0
commit 3e1e470
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/...pc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/tps/DefaultTPSLimiterTest.java b/...pc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/tps/DefaultTPSLimiterTest.java
@@ -29,16 +29,17 @@
 
 public class DefaultTPSLimiterTest {
 
+    private static final int TEST_LIMIT_RATE = 2;
     private DefaultTPSLimiter defaultTPSLimiter = new DefaultTPSLimiter();
 
     @Test
     public void testIsAllowable() throws Exception {
         Invocation invocation = new MockInvocation();
         URL url = URL.valueOf("test://test");
         url = url.addParameter(INTERFACE_KEY, "org.apache.dubbo.rpc.file.TpsService");
-        url = url.addParameter(TPS_LIMIT_RATE_KEY, 2);
+        url = url.addParameter(TPS_LIMIT_RATE_KEY, TEST_LIMIT_RATE);
         url = url.addParameter(TPS_LIMIT_INTERVAL_KEY, 1000);
-        for (int i = 0; i < 3; i++) {
+        for (int i = 1; i <= TEST_LIMIT_RATE; i++) {
             Assertions.assertTrue(defaultTPSLimiter.isAllowable(url, invocation));
         }
     }
@@ -48,10 +49,10 @@ public void testIsNotAllowable() throws Exception {
         Invocation invocation = new MockInvocation();
         URL url = URL.valueOf("test://test");
         url = url.addParameter(INTERFACE_KEY, "org.apache.dubbo.rpc.file.TpsService");
-        url = url.addParameter(TPS_LIMIT_RATE_KEY, 2);
+        url = url.addParameter(TPS_LIMIT_RATE_KEY, TEST_LIMIT_RATE);
         url = url.addParameter(TPS_LIMIT_INTERVAL_KEY, 1000);
-        for (int i = 0; i < 4; i++) {
-            if (i == 3) {
+        for (int i = 1; i <= TEST_LIMIT_RATE + 1; i++) {
+            if (i == TEST_LIMIT_RATE + 1) {
                 Assertions.assertFalse(defaultTPSLimiter.isAllowable(url, invocation));
             } else {
                 Assertions.assertTrue(defaultTPSLimiter.isAllowable(url, invocation));
@@ -65,14 +66,17 @@ public void testConfigChange() throws Exception {
         Invocation invocation = new MockInvocation();
         URL url = URL.valueOf("test://test");
         url = url.addParameter(INTERFACE_KEY, "org.apache.dubbo.rpc.file.TpsService");
-        url = url.addParameter(TPS_LIMIT_RATE_KEY, 2);
+        url = url.addParameter(TPS_LIMIT_RATE_KEY, TEST_LIMIT_RATE);
         url = url.addParameter(TPS_LIMIT_INTERVAL_KEY, 1000);
-        for (int i = 0; i < 3; i++) {
+        for (int i = 1; i <= TEST_LIMIT_RATE; i++) {
             Assertions.assertTrue(defaultTPSLimiter.isAllowable(url, invocation));
         }
-        url = url.addParameter(TPS_LIMIT_RATE_KEY, 2000);
-        for (int i = 0; i < 3; i++) {
+        final int tenTimesLimitRate = TEST_LIMIT_RATE * 10;
+        url = url.addParameter(TPS_LIMIT_RATE_KEY, tenTimesLimitRate);
+        for (int i = 1; i <= tenTimesLimitRate; i++) {
             Assertions.assertTrue(defaultTPSLimiter.isAllowable(url, invocation));
         }
+
+        Assertions.assertFalse(defaultTPSLimiter.isAllowable(url, invocation));
     }
 }