Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the lib to work with dart >= 3.3.0 #480

Merged
merged 18 commits into from
Aug 25, 2024
Merged

Conversation

leonardocustodio
Copy link
Owner

@leonardocustodio leonardocustodio commented Aug 25, 2024

PR Type

enhancement, documentation


Description

  • Updated the package version in pubspec.yaml from 0.4.6 to 0.4.7.
  • Added a changelog entry for version 0.4.7, documenting a fix for the UnmodifiableUint8ListView issue on newer Dart versions.

Changes walkthrough 📝

Relevant files
Documentation
CHANGELOG.md
Update changelog for version 0.4.7 with recent fixes         

packages/polkadart/CHANGELOG.md

  • Added entry for version 0.4.7.
  • Documented fix for UnmodifiableUint8ListView issue on newer Dart
    versions.
  • +3/-0     
    Enhancement
    pubspec.yaml
    Bump package version to 0.4.7                                                       

    packages/polkadart/pubspec.yaml

    • Updated package version from 0.4.6 to 0.4.7.
    +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link

    github-actions bot commented Aug 25, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @justkawal
    Copy link
    Collaborator

    LGTM

    @leonardocustodio leonardocustodio changed the title Bump version Upgrade the lib to work with dart >= 3.3.0 Aug 25, 2024
    @leonardocustodio leonardocustodio merged commit c3d0122 into main Aug 25, 2024
    14 checks passed
    @leonardocustodio leonardocustodio deleted the bump-version branch August 25, 2024 17:29
    Copy link

    codecov bot commented Aug 25, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 48.46%. Comparing base (2b3416c) to head (401a159).
    Report is 1 commits behind head on main.

    Additional details and impacted files

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##             main     #480   +/-   ##
    =======================================
      Coverage   48.46%   48.46%           
    =======================================
      Files         181      181           
      Lines        9575     9575           
    =======================================
      Hits         4641     4641           
      Misses       4934     4934           
    Flag Coverage Δ
    polkadart 15.91% <ø> (ø)
    polkadart_cli 12.02% <ø> (ø)
    polkadart_keyring 65.24% <ø> (ø)
    polkadart_scale_codec 54.93% <ø> (ø)
    secp256k1_ecdsa 89.60% <ø> (ø)
    sr25519 85.91% <ø> (ø)
    ss58 96.87% <ø> (ø)
    substrate_bip39 56.37% <ø> (ø)
    substrate_metadata 87.72% <ø> (ø)

    Flags with carried forward coverage won't be shown. Click here to find out more.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants