Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest from azure dev #24

Merged
merged 35 commits into from
Jun 4, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
0fffa38
ppg create: `--type` is now optional. (#9391)
adewaleo May 15, 2019
06959cf
[functionapps] Improvements of devops-pipeline command (#9383)
May 15, 2019
10ddfee
role assignment: support scope of management group (#9321)
yugangw-msft May 15, 2019
eb20935
[function-app]: wording change from iteractive to interactive (#9402)
May 15, 2019
d32ae69
[Network] NAT Gateway support (#9379)
tjprescott May 15, 2019
f5811bc
[ACR] Support Managed Identities for Task (#9317)
jaysterp May 16, 2019
b58bea8
[webapp]Fixing bug where the result was not showing the ASP (#9408)
panchagnula May 16, 2019
f8cae01
BotService 0.2.1: Update help text, minor UX improvements (#9412)
stevengum May 16, 2019
ede98f5
Add support for Manual-Failover (#9413)
anusapan May 17, 2019
781320f
[core] Fix bug where --query cannot be used with --output yaml (#9403)
adewaleo May 20, 2019
0b40e75
update default log analytics workspace region mapping for aks monitor…
ganga1980 May 20, 2019
0bab75c
Fix JP installer line (#9438)
marstr May 20, 2019
6bf4f77
ACS - OSA - Whitelist message (#9409)
julienstroheker May 20, 2019
65f852a
release: update versions (#9418)
yugangw-msft May 16, 2019
6868f1f
[vm] Fix bug introduced in #9306. (#9421)
adewaleo May 17, 2019
1beb635
auth: handle unicode in subscription name when under python 2.7 (#9439)
yugangw-msft May 22, 2019
eece82c
role: update the help of --assignee-object-id (#9457)
yugangw-msft May 23, 2019
c234eac
Update error logging for reported unclear issues (#9180)
bgklein May 23, 2019
e991191
Enable/Disable AKS kube-dashboard addon (#9458)
zhedahht May 24, 2019
a933916
Added ACR command to create a buildpack task (#9366)
May 24, 2019
45579ca
Make the RPM Spec flexible to EL7 vs EL8 (#9394)
marstr May 28, 2019
cd0c342
[ACR] Return patch response directly for acr repository update (#9420)
djyou May 28, 2019
e3ab833
Fixing Dockerfile name of RPM builder for centos in pipeline definiti…
marstr May 28, 2019
6bb0734
test: fix a flaky test (#9494)
yugangw-msft May 29, 2019
d4b196d
Update _help.py (#9502)
macedogm May 29, 2019
c63361a
Added Error Message when no TTY is available (#9481)
jdeschenes May 30, 2019
250a590
[Network] AppGateway WAF Policy commands (#9470)
tjprescott May 30, 2019
3bdff7e
[vm] create now more intelligently uses image data disk lun info. (#9…
adewaleo May 30, 2019
99f4180
Fixed registry prefix check (#9509)
dorfire May 30, 2019
a61f180
Update CLI to use Knack 0.6.2 (preview mechanism) (#9456)
tjprescott May 31, 2019
b9596ff
Network API 2019-04-01 (#9523)
tjprescott May 31, 2019
3ff2c5f
support ssh_public_key (#9512)
aim-for-better May 31, 2019
29d0671
Fix #9489. (#9531)
tjprescott May 31, 2019
457e6f0
Fix #9443. (#9533)
tjprescott Jun 3, 2019
d1f11f3
ServiceBus: Fix for Issue 9319 (#9538)
Jun 3, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[vm] Fix bug introduced in Azure#9306. (Azure#9421)
  • Loading branch information
adewaleo authored and yugangw-msft committed May 22, 2019
commit 6868f1f8d8e4b30391426908dcca75f7188d2e7e
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ def load_arguments(self, _):
c.argument('generate_ssh_keys', action='store_true', help='Generate SSH public and private key files if missing. The keys will be stored in the ~/.ssh directory')
c.argument('admin_username', help='Username for the VM.', default=get_default_admin_username())
c.argument('admin_password', help="Password for the VM if authentication type is 'Password'.")
c.argument('ssh_key_value', options_list=['--ssh-key-values'], completer=FilesCompleter(), type=file_type, nargs='*')
c.argument('ssh_key_value', options_list=['--ssh-key-values'], completer=FilesCompleter(), type=file_type, nargs='+')
c.argument('ssh_dest_key_path', help='Destination file path on the VM for the SSH key. If the file already exists, the specified key(s) are appended to the file.')
c.argument('authentication_type', help='Type of authentication to use with the VM. Defaults to password for Windows and SSH public key for Linux. "all" enables both ssh and password authentication. ', arg_type=get_enum_type(['ssh', 'password', 'all']))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,10 @@ def build_vmss_resource(cmd, name, naming_prefix, location, tags, overprovision,
vmss_properties['platformFaultDomainCount'] = platform_fault_domain_count

if ultra_ssd_enabled is not None:
vmss_properties['virtualMachineProfile']['additionalCapabilities'] = {'ultraSSDEnabled': ultra_ssd_enabled}
if cmd.supported_api_version(min_api='2019-03-01', operation_group='virtual_machine_scale_sets'):
vmss_properties['additionalCapabilities'] = {'ultraSSDEnabled': ultra_ssd_enabled}
else:
vmss_properties['virtualMachineProfile']['additionalCapabilities'] = {'ultraSSDEnabled': ultra_ssd_enabled}

if proximity_placement_group:
vmss_properties['proximityPlacementGroup'] = {'id': proximity_placement_group}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ def validate_ssh_key(namespace):
namespace.ssh_key_value = processed_ssh_key_values
# if no ssh keys processed, try to generate new key / use existing at root.
else:
namespace.ssh_key_value = _validate_ssh_key_helper("", namespace.generate_ssh_keys)
namespace.ssh_key_value = [_validate_ssh_key_helper("", namespace.generate_ssh_keys)]


def _validate_ssh_key_helper(ssh_key_value, should_generate_ssh_keys):
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.