Require asnlib ^1.5.0, fix resulting null-awareness warnings
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require asn1lib `^1.5.0` which among other things makes nullability changes to its API - Fix the resulting null-awareness warnings in lib/src/algorithms/rsa.dart
|
Hmm, when I test against this branch my program isn't working properly any more. |
Ah that was a problem with my test program, not this package. However the reason for it was the change in behaviour in the |
…ng now that min SDK version is Dart 3 because that's what `asn1lib` package requires as of 4 days ago. The failures were primarily due to changes in the File class in Dart 3 which were incompatible with pub.dev/packages/file v6.1.0
|
Sorry, didn't saw your PR before. Can you resolve the conflicts? |
Done |
# Conflicts: # CHANGELOG.md # pubspec.lock # pubspec.yaml
|
@leocavalcante was coming to file a bug on this issue. But see its been resolved. When do you think you'll get time to publish the latest version? pub shows 5.0.1 from 2 years go. Wondering if we can get 5.0.4 released. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #304