-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observe attributes and update options on change. Update default text on every attribute update. #128
Conversation
Hi @vstene. Thanks for your PR. I've just take this project and I would like to know about your scenario. Could you please explain me why would be necessary? Would you mind creating a plunkr for me? You can fork from this example though: http://plnkr.co/edit/1U8KCH?p=preview Thanks |
Hello @leocaseiro, I have a multi language app and I need to refresh the text attributes on language change. The problem seems to be that the attributes are not binded. For example, when changing the scope variable the text is not updated: From the current version of my fork the binding is applied via Hope this helps. |
Hi @vstene thank you for your reply. I liked it. I'm going to resolve some conflicts and them I'll accept your PR. I just would remove the reference from chosen.set_default_text() which gives me a warning:
|
So we don't need the methods disableWithMessage() and removeEmptyMessage() as the updateMessage() would work for both, right? |
I created the branch 128-vind-placeholder-text-single which should fix your issue. I resolved all conflicts with the last PR's. Could you please double check if works for you? Thanks |
I don't remember the reason for the |
No description provided.