Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: frame errors on MacOS Ventura #266

Merged
merged 1 commit into from
Nov 13, 2022
Merged

hotfix: frame errors on MacOS Ventura #266

merged 1 commit into from
Nov 13, 2022

Conversation

Ahmadre
Copy link
Contributor

@Ahmadre Ahmadre commented Nov 13, 2022 •
edited
Loading

Related Issues

Context

After users start sidekick on MacOS Ventura (>= 13.*), the issues in the above related issue are appearing.

What this PR solves

  • Fixes flutter_acrylic and bitsdojo_window native code in MainFlutterWindow.swift
  • False calculation due to deprecated native code in MainFlutterWindow.swift
  • Dependencies depending on MacOS Deployment Target < 10.13.* are overriden now to 10.14

@aguilaair aguilaair self-requested a review November 13, 2022 23:12
@aguilaair aguilaair assigned aguilaair and Ahmadre and unassigned aguilaair Nov 13, 2022
@aguilaair aguilaair added the bug Something isn't working label Nov 13, 2022
@aguilaair aguilaair merged commit 2376ffd into leoafarias:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguilaair aguilaair aguilaair approved these changes

Assignees

@Ahmadre Ahmadre

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ahmadre @aguilaair